There's another consideration now. We've seen how pants on head retarded NATO's combat tactics are in a peer warfare. It's not for nothing that Ukraine started finally seeing more success in this "offensive" once they started telling the American advisors to F-off and began using their own tactics in-house.
I would avoid combat arms and focus on something that has direct relevancy to a civilian career. For most people this means working in a business area like accounting (finance branch), logistics (ammo, transportation branches), maintenance, piloting (non-combat aircraft), etc. Those give you full benefits and any "cool guy" points you get will be more than made up for by having direct experience in the job you want to do.
Exceptions apply if your dream job is being a glowie, mercenary, or cop (same thing as mercenary). In that case go infantry and get into Airborne or SF.
I think combat arms can still be a good option if you gun for a SOF unit. I probably wouldn't recommend intentionally going line infantry, although you need to recognize that SOF units have low selection rates for a reason as as such you may end up there. Aviation is great too, other than that I'd go with something that teaches some sort of trade or hard skill, or possibly a language.